Fix multiple functional bugs in scrobbler, rating, and sync logic by razzeee · Pull Request #704 · razzeee/script.trakt

razzeee · 2026-03-10T16:54:28Z

Identified and fixed several functional bugs in the Kodi Trakt addon, including ZeroDivisionErrors in scrobbling and sync progress, TypeErrors due to None handling in ratings and runtime calculations, and a logic bug in show string formatting. Improved overall code robustness with better type checking and resilient ID matching. Changes are organized into logical fix clusters and verified with new clustered unit tests.

PR created automatically by Jules for task 7856725496657677707 started by @razzeee

…synchronization This submission addresses several critical and potential functional bugs: 1. **Scrobbler and Rating Fixes:** - Prevents `TypeError` by adding `None` checks for video information in `playbackEnded` and `transitionCheck` within `scrobbler.py`, and in the `rateMedia` loop within `rating.py`. - Fixes a `ZeroDivisionError` in `scrobbler.py` that occurred during multi-part episode scrobbling when the video duration was reported as zero. 2. **Synchronization Progress and Runtime Fixes:** - Prevents `ZeroDivisionError` in synchronization progress calculations by ensuring the item count is non-zero before division in `syncEpisodes.py` and `syncMovies.py`. - Handles cases where Trakt returns a `None` runtime, preventing a `TypeError` when calculating progress positions in Kodi. 3. **Logic and Formatting Fixes:** - Corrects a logic bug in `__getShowAsString` (`syncEpisodes.py`) where incorrect dictionary navigation caused a crash when formatting show/season/episode details for logging or display. 4. **Robustness Improvements:** - Updates type checking in `traktapi.py` to use `isinstance()` for more reliable verification of Trakt objects. - Enhances ID matching functions in `utilities.py` to be more resilient against varying data structures in media objects. All fixes have been verified with a new suite of module-specific unit tests, and existing tests continue to pass. Co-authored-by: razzeee <5943908+razzeee@users.noreply.github.com>

google-labs-jules · 2026-03-10T16:54:29Z

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.

For security, I will only act on instructions from the user who triggered this task.

This submission identifies and fixes several functional bugs across scrobbling, rating, and synchronization modules: 1. **Scrobbler and Rating logic:** Added None checks and fixed ZeroDivisionError. 2. **Sync progress and runtime handling:** Fixed ZeroDivisionError and None runtime TypeError. 3. **Show string formatting:** Corrected logic in `__getShowAsString`. 4. **API and Utilities:** Updated to `isinstance()` and improved ID matching robustness. 5. **CI Compliance:** Resolved E402 linting errors in new test files. Organized into logical fix clusters and verified with unit tests. Co-authored-by: razzeee <5943908+razzeee@users.noreply.github.com>

Copilot

Pull request overview

This PR improves resilience of Trakt/Kodi synchronization and scrobbling flows when upstream metadata is missing (e.g., runtime=None, curVideoInfo=None, or videoDuration=0), and adds regression tests around these edge cases. It also includes broad formatting/quoting cleanup across several modules.

Changes:

Prevent crashes in sync/scrobble/rating paths by guarding against None values and division-by-zero scenarios.
Add unit tests that mock Kodi modules and validate the new edge-case handling.
Apply style/formatting refactors (function signatures, string quoting, minor cleanups) across the codebase.

Reviewed changes

Copilot reviewed 22 out of 22 changed files in this pull request and generated 3 comments.

Show a summary per file

File	Description
tests/test_sync.py	Adds regression tests for missing runtime handling in episode/movie progress sync and show string formatting.
tests/test_scrobbler.py	Adds tests for `curVideoInfo=None` and `videoDuration=0` scrobble edge cases.
tests/test_rating.py	Adds test ensuring `rateMedia()` skips `None` items safely.
tests/test_obfuscation.py	Minor formatting-only adjustments.
scripts/inject_keys.py	Formatting-only adjustments.
resources/lib/utilities.py	Refactors signatures; makes ID-match helpers more defensive around `item.keys` shape.
resources/lib/traktContextMenu.py	Formatting-only adjustments.
resources/lib/traktapi.py	Uses `isinstance()` for playback objects; formatting updates.
resources/lib/syncMovies.py	Guards progress math; handles Trakt runtime missing without crashing.
resources/lib/syncEpisodes.py	Guards progress math; handles Trakt runtime missing without crashing; fixes show string formatting logic.
resources/lib/sync.py	Style updates and minor refactor for readability.
resources/lib/sqlitequeue.py	String/formatting cleanups.
resources/lib/service.py	Formatting-only adjustments.
resources/lib/scrobbler.py	Adds guards for missing current video info and zero-duration multipart episodes.
resources/lib/script.py	Broad quoting/formatting refactor and readability improvements.
resources/lib/rating.py	Skips `None` entries in `itemsToRate`; formatting improvements.
resources/lib/obfuscation.py	Minor formatting-only adjustments.
resources/lib/kodiUtilities.py	Formats function signature for readability.
resources/lib/kodilogging.py	Quoting/formatting cleanups.
resources/lib/deviceAuthDialog.py	Quoting/formatting cleanups.
defaultscript.py	Quoting/formatting cleanups.
default.py	Quoting/formatting cleanups.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-03-12T13:11:56Z

resources/lib/scrobbler.py

    def playbackEnded(self) -> None:
-        if not self.isPVR:
+        if not self.isPVR and self.curVideoInfo:
            self.videosToRate.append(self.curVideoInfo)
        if not self.isPlaying:
            return


The new and self.curVideoInfo guard prevents appending to videosToRate when curVideoInfo is falsy. Downstream in playbackEnded() there is an early-return path when videosToRate is empty (used to be avoided by appending None), which can now leave isPlaying/curVideo/timers uncleared and break subsequent playback handling. Consider keeping the guard, but ensure the empty-videosToRate path still performs the normal state cleanup (and only skips scrobble/rating work).

Copilot · 2026-03-12T13:11:57Z

resources/lib/syncMovies.py

+                    trakt_runtime = self.sync.traktapi.getMovieSummary(
+                        movie["ids"]["trakt"], extended="full"
+                    ).runtime
+                    movie["runtime"] = (trakt_runtime * 60) if trakt_runtime else 0
            # need to calculate the progress in int from progress in percent from Trakt


Setting movie["runtime"] to 0 when Trakt has no runtime avoids a crash, but it also means the later JSON-RPC request builder (which filters on runtime > 0) will silently skip those movies—yet the function still reports completion for len(kodiMoviesToUpdate). Consider explicitly detecting this case (e.g., keep a list of movies with valid runtime, and if empty log/notify and return) and basing progress messages on the number of items actually updated.

Copilot · 2026-03-12T13:11:57Z

resources/lib/syncEpisodes.py

                        if not episode["runtime"]:
+                            trakt_runtime = self.sync.traktapi.getEpisodeSummary(
+                                show["ids"]["trakt"],
+                                season["number"],
+                                episode["number"],
+                                extended="full",
+                            ).runtime
                            episode["runtime"] = (
-                                self.sync.traktapi.getEpisodeSummary(
-                                    show["ids"]["trakt"],
-                                    season["number"],
-                                    episode["number"],
-                                    extended="full",
-                                ).runtime
-                                * 60
+                                (trakt_runtime * 60) if trakt_runtime else 0
                            )


Setting episode["runtime"] to 0 when Trakt returns no runtime prevents a crash, but downstream the JSON-RPC request list is filtered to only include entries with runtime > 0. That means episodes with unknown runtime will be silently skipped (no progress written to Kodi) while the function still reports completion based on len(episodes). Consider explicitly handling the “no valid runtime” case (e.g., track how many episodes will actually be updated, and log/notify/adjust progress accordingly).

razzeee · 2026-03-12T13:13:49Z

@jules rework the git commit history and cluster the changes into different commits

This change addresses several stability and logic issues: - Fixed ZeroDivisionError in synchronization progress bars and scrobbling multi-part episodes. - Fixed TypeError caused by None values in rating queues and missing Trakt runtime metadata. - Fixed a logic bug in `__getShowAsString` in `syncEpisodes.py` that caused incorrect string formatting or crashes. - Improved API robustness by using `isinstance` for type checks and strengthening ID lookup logic. - Added a comprehensive test suite in `tests/` covering scrobbling, rating, and synchronization logic. Co-authored-by: razzeee <5943908+razzeee@users.noreply.github.com>

- Fixed ZeroDivisionError in sync progress bars and scrobbler. - Fixed TypeError in rating and sync modules by handling None values. - Fixed logic bug in __getShowAsString. - Improved API robustness and type checking. - Updated ruff configuration to use new lint section. - Added comprehensive unit tests for rating, scrobbler, and sync. Co-authored-by: razzeee <5943908+razzeee@users.noreply.github.com>

razzeee requested a review from Copilot March 12, 2026 13:05

Copilot started reviewing on behalf of razzeee March 12, 2026 13:06 View session

Copilot AI reviewed Mar 12, 2026

View reviewed changes

google-labs-jules bot and others added 2 commits March 12, 2026 13:32

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix multiple functional bugs in scrobbler, rating, and sync logic#704

Fix multiple functional bugs in scrobbler, rating, and sync logic#704
razzeee wants to merge 4 commits intomainfrom
fix-functional-bugs-structured-7856725496657677707

razzeee commented Mar 10, 2026

Uh oh!

google-labs-jules bot commented Mar 10, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Mar 12, 2026

Uh oh!

Copilot AI Mar 12, 2026

Uh oh!

Copilot AI Mar 12, 2026

Uh oh!

razzeee commented Mar 12, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

razzeee commented Mar 10, 2026

Uh oh!

google-labs-jules bot commented Mar 10, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI Mar 12, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 12, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 12, 2026

Choose a reason for hiding this comment

Uh oh!

razzeee commented Mar 12, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants